#671: remove further_info_url for CMIP7#921
Draft
Lauren Boon (mo-laurenboon) wants to merge 2 commits into
Draft
#671: remove further_info_url for CMIP7#921Lauren Boon (mo-laurenboon) wants to merge 2 commits into
Lauren Boon (mo-laurenboon) wants to merge 2 commits into
Conversation
Collaborator
Author
|
NOTE: All CMIP7 functional tests currently fail, this will be resolved an additional changes made shortly |
Collaborator
Author
|
All tests now passing |
Collaborator
Matthew Mizielinski (matthew-mizielinski)
left a comment
Matthew Mizielinski (matthew-mizielinski)
left a comment
There was a problem hiding this comment.
a couple of thoughts
| """ | ||
| global_attributes = OrderedDict() | ||
| global_attributes['further_info_url'] = get_further_info_url(request) | ||
| if request.metadata.mip_era != "CMIP7": |
Collaborator
There was a problem hiding this comment.
we could check in the required_global_attributes in the CVs as to whether this is required, rather than assuming that it is only gone for CMIP7.
| self._request.metadata.sub_experiment_id, | ||
| self._request.metadata.variant_label) | ||
| return further_info_url | ||
| return 'none' |
Collaborator
There was a problem hiding this comment.
what does this do? do we end up with a global attribute that says "none" or does it get skipped?
Matthew Mizielinski (matthew-mizielinski)
requested changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #671